 Effie's Burning1991 · Jessop Brown | Jessop Brown |
| TThe Winslow Boy1989 · Arthur Winslow | Arthur Winslow |
 The Lady and the Highwayman1988 · Harry | Harry |
 The Story of a Recluse1987 · Voice of the Recluse | Voice of the Recluse |
 The Whistle Blower1986 · Bruce | Bruce |
 My Brother Tom1986 · Lockie McGibbon | Lockie McGibbon |
 Gunpowder1986 · Sir Anthony Phelps | Sir Anthony Phelps |
 The Shooting Party1985 · Tom Harker | Tom Harker |
 The Masks of Death1984 · Inspector Alec MacDonald | Inspector Alec MacDonald |
 The Last Giraffe1979 · Fielding | Fielding |
 The Medusa Touch1978 · Doctor Johnson | Doctor Johnson |
 Golden Rendezvous1977 · Dr. Marston | Dr. Marston |
 Spectre1977 · Inspector Cabell | Inspector Cabell |
| SSonntagsgeschichten1976 · Mr. Dunner | Mr. Dunner |
 Russian Roulette1975 · Brian Hardison | Brian Hardison |
| LLothian Landscape1974 · Narrator | Narrator |
 The Square of Three1973 · Major Browne | Major Browne |
 Madame Sin1972 · Commander Cavendish | Commander Cavendish |
| GGR Stein Refractories1972 · Narrator | Narrator |
 Kidnapped1971 · Charles Stewart | Charles Stewart |
 Scrooge1970 · Tom - Friend of Harry's | Tom - Friend of Harry's |
 The Great Inimitable Mr. Dickens1970 · The Narrator (voice) | The Narrator (voice) |
 Hamlet1969 · Horatio | Horatio |
 Run Wild, Run Free1969 · Mr. Ransome | Mr. Ransome |
 The Prime of Miss Jean Brodie1969 · Gordon Lowther | Gordon Lowther |
 Wind Versus Polygamy1968 · Father Joseph | Father Joseph |
| OOn the Run1968 · Mr. Mallory | Mr. Mallory |
 Danger Route1967 · Brian Stern | Brian Stern |
 The Night of the Generals1967 · Captain Engel | Captain Engel |
 Triple Cross1966 · British Sergeant Questioning Chapman (uncredited) | British Sergeant Questioning Chapman (uncredited) |
 The Fighting Prince of Donegal1966 · Captain Leeds | Captain Leeds |
 Cast a Giant Shadow1966 · James MacAfee | James MacAfee |
 Those Magnificent Men in Their Flying Machines or How I Flew from London to Paris in 25 Hours 11 Minutes1965 · MacDougal | MacDougal |
 The Ipcress File1965 · Jock Carswell | Jock Carswell |
 Daylight Robbery1964 · Police Sergeant | Police Sergeant |
 The Long Ships1964 · Vahlin | Vahlin |
 The Great Escape1963 · MacDonald 'Intelligence' | MacDonald 'Intelligence' |
 Mutiny on the Bounty1962 · Seaman Edward Birkett | Seaman Edward Birkett |
 Two Wives at One Wedding1961 · Dr. Thomas Murray | Dr. Thomas Murray |
 Greyfriars Bobby1961 · Farmer | Farmer |
 Tunes of Glory1960 · Capt. Jimmy Cairns, M.C. (Battalion Adjutant) | Capt. Jimmy Cairns, M.C. (Battalion Adjutant) |
 Cone of Silence1960 · Capt. Jock Bateson | Capt. Jock Bateson |
 Snowball1960 · Bill Donovan | Bill Donovan |
 Devil's Bait1959 · Sergeant Malcolm | Sergeant Malcolm |
 Yesterday's Enemy1959 · Sgt. MacKenzie | Sgt. MacKenzie |
 The Bridal Path1959 · PC Alec | PC Alec |
 Blind Date1959 · Sergeant | Sergeant |
 The Price of Silence1959 · Roger Fenton | Roger Fenton |
 The Navy Lark1959 · Leading Seaman Johnson | Leading Seaman Johnson |
 Rockets Galore1958 · George Campbell | George Campbell |
 Three Crooked Men1958 · Don Wescot | Don Wescot |
 Blind Spot1958 · 'Chalky' White | 'Chalky' White |
| BBlack Ice1957 · Hamish | Hamish |
 Man in the Shadow1957 · Jimmy Norris | Jimmy Norris |
 Hell Drivers1957 · Scottie | Scottie |
 Let's Be Happy1957 · Dougal McLean (uncredited) | Dougal McLean (uncredited) |
 Seven Waves Away1957 · John Merritt | John Merritt |
| TThe Film That Never Was1957 · Actor | Actor |
| SScotland Dances1957 · Narrator | Narrator |
 Sailor Beware1956 · Carnoustie Bligh | Carnoustie Bligh |
 Women Without Men1956 · Percy | Percy |
 The Baby and the Battleship1956 · Harry | Harry |
 Blonde Bait1956 · Percy | Percy |
 Pacific Destiny1956 · District Officer | District Officer |
 The Quatermass Xperiment1955 · BBC TV producer | BBC TV producer |
| WWindfall1955 · Leonard | Leonard |
 Moby Dick—Rehearsed1955 · A Young Actor /Ishmael | A Young Actor /Ishmael |
 Passage Home1955 · Ted Burns | Ted Burns |
 The Delavine Affair1955 · Peter J. Florian | Peter J. Florian |
 The Love Lottery1954 · Ralph | Ralph |
 Meet Mr. Lucifer1953 · Hector McPhee | Hector McPhee |
 Malta Story1953 · British Soldier | British Soldier |
 Death Goes to School1953 · Detective Inspector Campbell | Detective Inspector Campbell |
| TThe Schoolmaster1953 · Actor | Actor |
| SScotland and the New World1952 · Actor | Actor |
 Castle in the Air1952 · Hiker | Hiker |
 The Lady with a Lamp1951 · Dr. Anson | Dr. Anson |
 Happy Go Lovely1951 · Paul Tracy | Paul Tracy |
 Bitter Springs1950 · Mac | Mac |
 Whisky Galore!1949 · George Campbell | George Campbell |
 Stop Press Girl1949 · Jock Melville | Jock Melville |
 Floodtide1949 · David Shields | David Shields |
 Eureka Stockade1949 · Tom Kennedy | Tom Kennedy |
 Against the Wind1948 · Scotty Duncan | Scotty Duncan |
 The Captive Heart1946 · Lt. David Lennox | Lt. David Lennox |
 Pink String and Sealing Wax1945 · David Sutton | David Sutton |
 Pursuit to Algiers1945 · Steward (uncredited) | Steward (uncredited) |
 San Demetrio London1943 · Messboy John Jamieson - M.V. San Demetrio | Messboy John Jamieson - M.V. San Demetrio |
 Millions Like Us1943 · Fred Blake | Fred Blake |
 Nine Men1943 · Young 'un | Young 'un |
 The Foreman Went to France1942 · Alastair 'Jock' MacFarlan, 19th Fusillers | Alastair 'Jock' MacFarlan, 19th Fusillers |
 One of Our Aircraft Is Missing1942 · (uncredited) | (uncredited) |
